From nobody Mon Jan 16 08:29:39 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NwQDk5qgxz2t6r4; Mon, 16 Jan 2023 08:29:42 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NwQDk5FSzz3kv0; Mon, 16 Jan 2023 08:29:42 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673857782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sz+QysnnYsAczVYQt3l0hkvOVy0U3ExRLOwbJZTQw+Q=; b=vJZ+0mD/HL9YG8NFaAL+0VeZxPQQohDsKrxeMbPUpPsM9+jgTjJE66IDAqHzyfcwaSA2Le t10eKun03zfRtJ+uPKS2KgBg+MgAEiaJaKm8GpK5dDDLB3NCvkCRQ49ZHtrQ3xcb8JxEpb qNHy3IxoOdrOnmgnxy1jBNkHTghc40Yp+7btgkPOsSQSQhKgJgK0i04jLhdfSRV7/EKss9 Og6niq7U4hVca+iAUfmzxRQPa33zV3vwte3igKPlm6s0Fo0JgHOnGxlUXQrGh4LWVUI/dN RIt8iLlyvD0QscCiX8LNFkiiQJRRz6e3XrDIs81qVzlHkLn2mf/6Y4GlwvHtjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1673857782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sz+QysnnYsAczVYQt3l0hkvOVy0U3ExRLOwbJZTQw+Q=; b=S30dUf1VN/PnR+h7ZhjexohzuRyYCeK/5oE8Qlpaf4NEPRtBbAPOoXUofGENYg2WoC8Tqc WiwXmsjuyvaiydQHsALeiZ9j+oBPhlPYjWRPk9100plfy0ih+ESDDy5utciSTlk+esSfTi T0TzNcI7dSJnPWuE0KqOGXZAEIFiEQd+BB1xhE+kCtvvTbZ0ZAQlP3AUXnoQF6PI6wdtFe IBBNUJI1AG6LBTxSn6Fb5f1ryeEyfa7GzBRcckWYKGrwvCCSgwneJ0Qo8o52ITFi+VYvQW wqJHTtFknNalhl/EONq7N7RvnJyESKOWOAiaAZC26h/reCcxnj31fsIi8op0nQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1673857782; a=rsa-sha256; cv=none; b=uM5Kw/7HZlHkB5Z12xCNWb9pKNxQ5M63I00RqWvDmahzpOCy25709kzd8TkgtypXJoPNL3 maQSSPJ287vKCar1MNRGwC5UPr/n935WjcpV+ZvnOUWnz55EqovbsDJo5g8pPyxYdoHTcn SL+FihZ/GoZgRrYvFbBLADrl3rlZKoWavnfiDB9ZZUxKChCU6V9q0qbnRwbduEt/zVwSSC WmQiR3ubR2mwGY+bijZ651anBZIiTt73DWSfqBaVEtu+syk5Ugl/FDJLPKzSHKn5kL3YOD 6KzIGqzZQY/mKCobU8j6QWX9LEU6a3OjRVjaE6uNZJkKM+QYTdkpl6f7KheJ1Q== Received: from [172.24.42.13] (host-79-32-131-66.retail.telecomitalia.it [79.32.131.66]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4NwQDj6yt6zKl3; Mon, 16 Jan 2023 08:29:41 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: <94dafa12-af10-d5c3-ee0f-994dd1f11ced@FreeBSD.org> Date: Mon, 16 Jan 2023 09:29:39 +0100 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: git: dafb3cafaf77 - main - editors/ghostwriter: Fix Makefile causing errors To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202301152330.30FNUXUo054305@gitrepo.freebsd.org> Content-Language: en-US From: Guido Falsi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 16/01/23 09:07, Alexey Dokuchaev wrote: > On Sun, Jan 15, 2023 at 11:30:33PM +0000, Guido Falsi wrote: >> commit dafb3cafaf774e89c3ebd1500ce56fba5665da02 >> >> editors/ghostwriter: Fix Makefile causing errors >> >> Using FLAVOR?=${FLAVORS:[0]} confuses the ports make system. > > :[0] returns the whole string (after expansion), word enumeration > starts with one. I don't see where does confusion come from, just > use FLAVORS:[1] as documented in man make(1). Ideally it can be > dropped altogether (default flavor is set by b.p.m.) but since this > definition is not available immediately, it requires certain care.\ Yes thanks! I actually know this, but yesterday evening, when I performed this commit I was clearly tired and my mind simply overlooked this detail. Most probably I got confused with the usual array syntax in almost any other programming language I know. -- Guido Falsi