svn commit: r288099 - head/contrib/binutils/opcodes

[Dimitry Andric]

On 22 Sep 2015, at 11:43, Slawa Olhovchenkov <slw at zxy.spb.ru> wrote:
> 
> On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote:
...
>> -			  imm |= (-1 << 7);
>> +			  imm |= -(1 << 7);
> 
> May be (~0 << 7) is more simple to understund?

This will give the same warning.  ~0 will implicitly convert to -1.

(It would be better to convert all these masks to unsigned, where such
shifting is always defined, but that gives a lot more churn.)

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20150922/49826922/attachment.bin>