svn commit: r288099 - head/contrib/binutils/opcodes

Slawa Olhovchenkov slw at zxy.spb.ru
Tue Sep 22 09:43:05 UTC 2015


On Tue, Sep 22, 2015 at 09:35:35AM +0000, Dimitry Andric wrote:

> Author: dim
> Date: Tue Sep 22 09:35:35 2015
> New Revision: 288099
> URL: https://svnweb.freebsd.org/changeset/base/288099
> 
> Log:
>   In binutils' arm-dis.c, avoid left-shifting a negative number.
>   
>   Submitted by:	dan.mcgregor_usask.ca (Dan McGregor)
>   MFC after:	3 days
>   Differential Revision: https://reviews.freebsd.org/D3376
> 
> Modified:
>   head/contrib/binutils/opcodes/arm-dis.c
> 
> Modified: head/contrib/binutils/opcodes/arm-dis.c
> ==============================================================================
> --- head/contrib/binutils/opcodes/arm-dis.c	Tue Sep 22 07:40:55 2015	(r288098)
> +++ head/contrib/binutils/opcodes/arm-dis.c	Tue Sep 22 09:35:35 2015	(r288099)
> @@ -1767,7 +1767,7 @@ print_insn_coprocessor (bfd_vma pc, stru
>  
>  			/* Is ``imm'' a negative number?  */
>  			if (imm & 0x40)
> -			  imm |= (-1 << 7);
> +			  imm |= -(1 << 7);

May be (~0 << 7) is more simple to understund?


More information about the svn-src-all mailing list