svn commit: r282445 - stable/10/sys/netinet6

Mark Johnston markj at FreeBSD.org
Tue May 5 03:17:33 UTC 2015


Author: markj
Date: Tue May  5 03:17:32 2015
New Revision: 282445
URL: https://svnweb.freebsd.org/changeset/base/282445

Log:
  MFC r281483:
  Fix a possible refcount leak in regen_tmpaddr().

Modified:
  stable/10/sys/netinet6/nd6.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/netinet6/nd6.c
==============================================================================
--- stable/10/sys/netinet6/nd6.c	Tue May  5 03:13:02 2015	(r282444)
+++ stable/10/sys/netinet6/nd6.c	Tue May  5 03:17:32 2015	(r282445)
@@ -757,11 +757,10 @@ regen_tmpaddr(struct in6_ifaddr *ia6)
 		 * address with the prefix.
 		 */
 		if (!IFA6_IS_DEPRECATED(it6))
-		    public_ifa6 = it6;
-
-		if (public_ifa6 != NULL)
-			ifa_ref(&public_ifa6->ia_ifa);
+			public_ifa6 = it6;
 	}
+	if (public_ifa6 != NULL)
+		ifa_ref(&public_ifa6->ia_ifa);
 	IF_ADDR_RUNLOCK(ifp);
 
 	if (public_ifa6 != NULL) {


More information about the svn-src-all mailing list