svn commit: r212964 - head/sys/kern

[mdf at FreeBSD.org]

On Tue, Sep 21, 2010 at 8:40 AM, Andriy Gapon <avg at freebsd.org> wrote:
> on 21/09/2010 18:27 Andriy Gapon said the following:
>> on 21/09/2010 18:17 mdf at FreeBSD.org said the following:
>>>
>>> I'd recommend using stack_print_ddb(), as that avoids any locking
>>> which may hang depending on how the kernel panic'd.
>>
>> It seems that stack_print_ddb() depends on DDB?
>
> But the point about locking is very good.
> How do you suggest we can deal with it?
>
> A dirty hack would be to check panicstr in linker_search_symbol_name and avoid
> locking, but I don't like that at all.
> Perhaps, some code in subr_stack.c could be taken outside DDB ifdef?

I keep forgetting, but actually _mtx_lock_sleep() will just return if
panicstr is set.  _mtx_assert() is similarly guarded, so actually it
should be mostly okay.

Thanks,
matthew