svn commit: r533086 - in head: graphics/pcl-pointclouds graphics/vv math/vtk8 math/vtk8/files science/avogadrolibs science/liggghts

[Adriaan de Groot]

On 2020 prilula d. 27id 08:33:22 CEST Christoph Moench-Tegeder wrote:
> ## Yuri Victorovich (yuri at FreeBSD.org):
> > +post-install:
> > +	## 8.2 installs cmake files into a wrong location
> > +	#@cd ${STAGEDIR}${PREFIX} && \
> > +	#	${MV} lib/vtk-${VTK_SHORT_VER}/cmake lib/
> 
> The thought was great, but why did you comment this?
> Earlier vtk8 (8.1) installed it's cmake files in
> ${LOCALBASE}/lib/cmake/vtk-8.1/, now we've
> ${LOCALBASE}/lib/vtk-8.2/cmake/vtk-8.2 and e.g. opencascade can't
> find VTK. 



The litmus test should be if a plain find_package(VTK) -- at least, as plain 
as makes sense when finding VTK from a CMakeListstxt -- can find this one. It 
certainly looks unusual to have ${LOCALBASE}/<thing>/cmake/<thing>/ containing 
the CMake config files for <thing>.

I can't immediately tell from the documentation if find_package() looks there.

Note that it's not entirely unheard of -- zxing has lib/zxing/cmake rather 
than the more conventional lib/cmake/zxing.

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20200427/2b87bab7/attachment.sig>