svn commit: r501243 - head/net/freeswitch

[Adriaan de Groot]

On Saturday, 11 May 2019 11:55:40 CEST Tobias Kortkamp wrote:
>   net/freeswitch: Fix build and disable -Werror to stop collecting -Wno-*
> flags

Why not patch it to do the right thing? With patches you might even be able to 
move things upstream, .. or chase the latest release, since upstream seems to 
be doing monthlies now (there is a 1.8.5, which still contains the same 
problem).

The underlying error is that the code is doing, basically,

	strlen("derp"+1)

where it's adding one to a string constant; clang helpfully (? if you're used 
to javascript perhaps) tells you this isn't going to get you "derp1" as a 
string, but rather "erp" .. which is exactly what this code wants, but it 
could be done in a less-derpy and less error-prone way (e.g. &"derp"[1]).

I guess I'm saying I'm not a fan of turning off warnings and errors unless 
it's really hopeless upstream.

[ade]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20190511/8e0438bf/attachment.sig>