svn commit: r374800 - head/Mk/Uses

[Bryan Drewery]

On 12/16/2014 8:24 AM, Alexey Dokuchaev wrote:
> On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote:
>> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote:
>>> +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov <ak at FreeBSD.org> wrote:
>>> | Allow me to ask, why it should be 8 and not 4?
>>>
>>> Because a tabulation is 8 spaces.  It should be consistent over the whole
>>> ports tree.
>>
>> Well, 'Please view me with 4 column tabs!' line was added to bsd.port.mk
>> more than 20 year ago, in rev 69, because it's inconvenient to view it with
>> default tabulation value: many wrapped lines, indentation too deep, etc.
> 
> I think I agree with Alex here.  While most of us prefer ts=8, I don't see
> the need to reindent some files, most notably b.p.m., as it will completely
> jeopardize its history and make 'svn blame' basically useless.
> 
> Even with editors that cannot grok ex:ts=X hints, its not that hard to do it
> manually every time you need to view/edit these files.  I do it all the time
> with nvi(1).
> 
> ./danfe
> 

As a vendor who maintains a forked ports tree, I despise this commit and
all of the ones below. It makes carrying out customizations very
difficult. Yes, it doesn't *look* good on the eyes, but reindenting on
such large files with large history maintained by > 1 person is a sin.

r358259 | bapt | 2014-06-18 07:22:20 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358258 | bapt | 2014-06-18 07:21:35 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358255 | bapt | 2014-06-18 07:20:53 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358237 | bapt | 2014-06-18 04:43:38 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358236 | bapt | 2014-06-18 04:41:25 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358220 | bapt | 2014-06-18 02:30:24 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358219 | bapt | 2014-06-18 02:28:44 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358218 | bapt | 2014-06-18 02:26:25 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358217 | bapt | 2014-06-18 02:20:29 -0500 (Wed, 18 Jun 2014) | 2 lines

tabspace: 8

------------------------------------------------------------------------
r358215 | bapt | 2014-06-18 02:17:13 -0500 (Wed, 18 Jun 2014) | 2 lines

Switch to tabspace: 8

------------------------------------------------------------------------
r358214 | bapt | 2014-06-18 02:14:22 -0500 (Wed, 18 Jun 2014) | 2 lines

Switch to default tabspace: 8
------------------------------------------------------------------------
r358213 | bapt | 2014-06-18 02:13:26 -0500 (Wed, 18 Jun 2014) | 2 lines

Switch back to default tabspace: 8


-- 
Regards,
Bryan Drewery

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-head/attachments/20141216/0259fa23/attachment.sig>