svn commit: r528808 - head/net/nsq

[Mathieu Arnold]

On Sun, Mar 22, 2020 at 12:20:58PM +0100, Gerald Pfeifer wrote:
> Hi Mat,
> 
> On Sun, 22 Mar 2020, Mathieu Arnold wrote:
> >>>> +PORTREVISION=	2
> >>> Why bump PORTREVISION?
> >> John, as a bit more color: when a commit solely allows a port to build 
> >> that failed to build before, or build where it did not build before (OS 
> >> version, architecture,...) we don't usually bump PORTREVISION.
> > I do not understand what is so hard with understanding why PORTREVISION
> > exists.
> 
> was this directed at me, or a general note?
> 
> If the former, yes, I could (should) have omitted the word "usually"
> since I had "solely" at the beginning of the sentence.  Apart from 
> that softness, I don't sense disagreement; is there?

It was not directed at you.  My point is that we define usage as
things that needs to be done, not things that needs to not be done.
Like, "you use PORTREVISION when the package version does not change and
needs to be rebuilt", not like "You do not use PORTREVISION in X case".

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20200323/0af0f792/attachment.sig>