svn commit: r510145 - head/sysutils/screen
Cy Schubert
Cy.Schubert at cschubert.com
Thu Aug 29 12:54:22 UTC 2019
In message <20190829124225.r7gpumnvtbeguuoz at ivaldir.net>, Baptiste
Daroussin wr
ites:
>
>
> --vmfceac25l47d6el
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
>
> On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote:
> > In message <201908290638.x7T6cVFc033808 at repo.freebsd.org>, Kirill Ponomar=
> ev=20
> > wri
> > tes:
> > > Author: krion
> > > Date: Thu Aug 29 06:38:31 2019
> > > New Revision: 510145
> > > URL: https://svnweb.freebsd.org/changeset/ports/510145
> > >
> > > Log:
> > > Remove building man page by default. It's currently broken on HEAD
> > > and requires to build textproc/groff which requires devel/llvm80
> > > which is an overkill for using screen.
> > >
> > > Modified:
> > > head/sysutils/screen/Makefile
> > >
> > > Modified: head/sysutils/screen/Makefile
> > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
> =3D=3D=3D=3D
> > > =3D
> > > --- head/sysutils/screen/Makefile Thu Aug 29 06:37:17 2019 (r51014
> > > 4)
> > > +++ head/sysutils/screen/Makefile Thu Aug 29 06:38:31 2019 (r51014
> > > 5)
> > > @@ -3,7 +3,7 @@
> > > =20
> > > PORTNAME=3D screen
> > > PORTVERSION=3D 4.6.2
> > > -PORTREVISION=3D 1
> > > +PORTREVISION=3D 2
> > > CATEGORIES=3D sysutils
> > > MASTER_SITES=3D GNU \
> > > ftp://ftp.gnu.org/gnu/screen/ \
> > > @@ -20,7 +20,7 @@ COMMENT=3D Multi-screen window manager
> > > LICENSE=3D GPLv3
> > > =20
> > > OPTIONS_DEFINE=3D INFO MAN NETHACK XTERM_256 SHOWENC SYST
> EM_SCREE
> > > NRC
> > > -OPTIONS_DEFAULT=3D INFO MAN NETHACK XTERM_256 SOCKETS SYSTEM_SCREE
> NRC \
> > > +OPTIONS_DEFAULT=3D INFO NETHACK XTERM_256 SOCKETS SYSTEM_SCREENRC
> \
> > > NCURSES_DEFAULT
> > > OPTIONS_SINGLE=3D IPC NCURSES
> > > OPTIONS_SINGLE_IPC=3D SOCKETS NAMED_PIPES
> > >
> >=20
> > Should you not have obtained maintainer approval for this first?
> >=20
> > And now the package will not include man pages. Can I assign those PRs to=
> =20
> > you?
> >=20
>
> I do think the best approach to this is to drop the MAN page option, it mak=
> es
> little sense not to install it. and not add groff as a runtime dependency
> anyway.
I've had this same issue with krb5. Pkg end users expect man pages.
>
> The reason why man(1) is telling the users to install groff(1) is exactly f=
> or
> that, the users do decide if he wants to read that manpage on his system an=
> d do
> install groff, or he reads it online and do not install it at all. the other
> point is in the future screen(1) might become mandoc compatible. and you wi=
> ll
> still grab in the groff(1) dependency.
I'm willing to live with this but it is still disrespectful not to involve
the maintainer.
Can I point to this email thread as a precedent if or when I commit to a
port maintained by someone else?
>
> Best regards,
> Bapt
--
Cheers,
Cy Schubert <Cy.Schubert at cschubert.com>
FreeBSD UNIX: <cy at FreeBSD.org> Web: http://www.FreeBSD.org
The need of the many outweighs the greed of the few.
More information about the svn-ports-all
mailing list