svn commit: r510145 - head/sysutils/screen

[Baptiste Daroussin]

On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote:
> In message <201908290638.x7T6cVFc033808 at repo.freebsd.org>, Kirill Ponomarev 
> wri
> tes:
> > Author: krion
> > Date: Thu Aug 29 06:38:31 2019
> > New Revision: 510145
> > URL: https://svnweb.freebsd.org/changeset/ports/510145
> >
> > Log:
> >   Remove building man page by default. It's currently broken on HEAD
> >   and requires to build textproc/groff which requires devel/llvm80
> >   which is an overkill for using screen.
> >
> > Modified:
> >   head/sysutils/screen/Makefile
> >
> > Modified: head/sysutils/screen/Makefile
> > =============================================================================
> > =
> > --- head/sysutils/screen/Makefile	Thu Aug 29 06:37:17 2019	(r51014
> > 4)
> > +++ head/sysutils/screen/Makefile	Thu Aug 29 06:38:31 2019	(r51014
> > 5)
> > @@ -3,7 +3,7 @@
> >  
> >  PORTNAME=	screen
> >  PORTVERSION=	4.6.2
> > -PORTREVISION=	1
> > +PORTREVISION=	2
> >  CATEGORIES=	sysutils
> >  MASTER_SITES=	GNU \
> >  		ftp://ftp.gnu.org/gnu/screen/ \
> > @@ -20,7 +20,7 @@ COMMENT=	Multi-screen window manager
> >  LICENSE=	GPLv3
> >  
> >  OPTIONS_DEFINE=		INFO MAN NETHACK XTERM_256 SHOWENC SYSTEM_SCREE
> > NRC
> > -OPTIONS_DEFAULT=	INFO MAN NETHACK XTERM_256 SOCKETS SYSTEM_SCREENRC \
> > +OPTIONS_DEFAULT=	INFO NETHACK XTERM_256 SOCKETS SYSTEM_SCREENRC \
> >  			NCURSES_DEFAULT
> >  OPTIONS_SINGLE=		IPC NCURSES
> >  OPTIONS_SINGLE_IPC=	SOCKETS NAMED_PIPES
> >
> 
> Should you not have obtained maintainer approval for this first?
> 
> And now the package will not include man pages. Can I assign those PRs to 
> you?
> 

I do think the best approach to this is to drop the MAN page option, it makes
little sense not to install it. and not add groff as a runtime dependency
anyway.

The reason why man(1) is telling the users to install groff(1) is exactly for
that, the users do decide if he wants to read that manpage on his system and do
install groff, or he reads it online and do not install it at all. the other
point is in the future screen(1) might become mandoc compatible. and you will
still grab in the groff(1) dependency.

Best regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20190829/2ea5af4a/attachment.sig>