svn commit: r436980 - in head/comms/fldigi: . files

[Diane Bruce]

On Mon, Mar 27, 2017 at 01:16:59AM +0200, Jan Beich wrote:
> Diane Bruce <db at FreeBSD.org> writes:
> 
> > +-			if ((ptr2) > 0 && (unsigned)(ptr2 - ptr) <= p)
> > ++			if ((unsigned long)(ptr2) > 0 && (unsigned long)(ptr2 - ptr) <= p)
> 
> Why not compare pointer against NULL? Some architectures may have
> pointer type larger than "unsigned long".
> 
> Also see the patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199
> which fixes some Clang warnings.
> 

Because since I know there is a new upcoming release from upstream
I was concentrating my efforts on getting your diffs plus some others
into the upcoming fldigi 4.0.0 . It would be rather nice to not have
all those diffs cluttering up the port now wouldn't it.

-- 
- db at FreeBSD.org db at db.net http://www.db.net/~db