svn commit: r436980 - in head/comms/fldigi: . files

Sun Mar 26 23:15:34 UTC 2017

Diane Bruce <db at FreeBSD.org> writes:

> +-			if ((ptr2) > 0 && (unsigned)(ptr2 - ptr) <= p)
> ++			if ((unsigned long)(ptr2) > 0 && (unsigned long)(ptr2 - ptr) <= p)

Why not compare pointer against NULL? Some architectures may have
pointer type larger than "unsigned long".

Also see the patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216199
which fixes some Clang warnings.