svn commit: r448610 - in head/devel/leatherman: . files

[Mathieu Arnold]

Le 24/08/2017 à 14:34, Romain Tartière a écrit :
> On Thu, Aug 24, 2017 at 02:12:32PM +0200, Thierry Thomas wrote:
>> Le mer. 23 août 17 à 16:08:36 +0200, Romain Tartière <romain at FreeBSD.org>
>>  écrivait :
>>
>>> Another point with `make makepatch`: in the post-patch target, I alter
>>> the patched source code.  `make makepatch` wants the combined patches to
>>> be combined:
>>>
>>> ---------------------------------- 8< ----------------------------------
>>> -+        return "%%PREFIX%%/etc/facter/facter.conf";
>>> ++        return "/usr/local/etc/facter/facter.conf";
>>> ---------------------------------- 8< ----------------------------------
>> This is why this kind of substitutions are better in pre-configure.
>> Logically, post-patch is for static replacements, not for variables
>> depending on the configuration options.
> Makes sense.  I found a warkaround (make extract do-patch makepatch),
> but this solution seems definitively better.


But pre-configure must not be used for patching. All patching must
happen in the patch phase.  It is supposed to be used to set things up
before the configure script runs.


-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170824/8ad9246e/attachment.sig>