svn commit: r448610 - in head/devel/leatherman: . files

[Romain Tartière]

On Thu, Aug 24, 2017 at 02:12:32PM +0200, Thierry Thomas wrote:
> Le mer. 23 août 17 à 16:08:36 +0200, Romain Tartière <romain at FreeBSD.org>
>  écrivait :
> 
> > Another point with `make makepatch`: in the post-patch target, I alter
> > the patched source code.  `make makepatch` wants the combined patches to
> > be combined:
> > 
> > ---------------------------------- 8< ----------------------------------
> > -+        return "%%PREFIX%%/etc/facter/facter.conf";
> > ++        return "/usr/local/etc/facter/facter.conf";
> > ---------------------------------- 8< ----------------------------------
> 
> This is why this kind of substitutions are better in pre-configure.
> Logically, post-patch is for static replacements, not for variables
> depending on the configuration options.

Makes sense.  I found a warkaround (make extract do-patch makepatch),
but this solution seems definitively better.

Thanks Thierry!

-- 
Romain Tartière <romain at FreeBSD.org>  http://people.FreeBSD.org/~romain/
pgp: 8234 9A78 E7C0 B807 0B59  80FF BA4D 1D95 5112 336F (ID: 0x5112336F)
(plain text =non-HTML= PGP/GPG encrypted/signed e-mail much appreciated)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170824/23813952/attachment.sig>