svn commit: r447474 - head/www/rubygem-goldfinger

[Mathieu Arnold]

Le 08/08/2017 à 20:57, Sunpoet Po-Chuan Hsieh a écrit :
> On Mon, Aug 7, 2017 at 4:53 AM, Mathieu Arnold <mat at freebsd.org
> <mailto:mat at freebsd.org>> wrote:
>
>     Hi,
>
>     Le 06/08/2017 à 18:53, Sunpoet Po-Chuan Hsieh a écrit :
>     > Author: sunpoet
>     > Date: Sun Aug  6 16:53:09 2017
>     > New Revision: 447474
>     > URL: https://svnweb.freebsd.org/changeset/ports/447474
>     <https://svnweb.freebsd.org/changeset/ports/447474>
>     >
>     > Log:
>     >   Use PORTVERSION
>
>     Please revert. DISTVERSION is the preferred way of setting upstream's
>     version.
>
>     https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-versions
>     <https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#makefile-versions>
>
>
> Hi mat,
>
> Here's my reason of this change. (jrm@ is cc'd).
> The majority of the ports tree (and almost all rubygem ports) use
> PORTVERSION. [1]
> It's my understanding that we use PORTVERSION in most cases.

Yes, it is because it took me a while to document that we should all be
using DISTVERSION and almost never PORTVERSION.

> When upstream use versions like 1_2_3, 4.5-alpha6 or so, we use
> DISTVERSION instead.
>
> Before I revert it, could you make it clear when to use PORTVERSION
> and DISTVERSION?

It is explained in the porter's handbook, always use DISTVERSION except
when there is no version in the distribution file, or when DISTVERSION
gives an incorrect PORTVERSION.

-- 
Mathieu Arnold


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20170809/9ae2a61c/attachment.sig>