svn commit: r447474 - head/www/rubygem-goldfinger

[Sunpoet Po-Chuan Hsieh]

On Mon, Aug 7, 2017 at 4:53 AM, Mathieu Arnold <mat at freebsd.org> wrote:

> Hi,
>
> Le 06/08/2017 à 18:53, Sunpoet Po-Chuan Hsieh a écrit :
> > Author: sunpoet
> > Date: Sun Aug  6 16:53:09 2017
> > New Revision: 447474
> > URL: https://svnweb.freebsd.org/changeset/ports/447474
> >
> > Log:
> >   Use PORTVERSION
>
> Please revert. DISTVERSION is the preferred way of setting upstream's
> version.
>
> https://www.freebsd.org/doc/en/books/porters-handbook/makefi
> le-naming.html#makefile-versions


Hi mat,

Here's my reason of this change. (jrm@ is cc'd).
The majority of the ports tree (and almost all rubygem ports) use
PORTVERSION. [1]
It's my understanding that we use PORTVERSION in most cases.
When upstream use versions like 1_2_3, 4.5-alpha6 or so, we use DISTVERSION
instead.

Before I revert it, could you make it clear when to use PORTVERSION and
DISTVERSION?

Thanks.

[1]
Search PORTVERSION in Makefile:
https://github.com/freebsd/freebsd-ports/search?l=Makefile&
q=PORTVERSION&type=&utf8=%E2%9C%93
24,869 code results in freebsd/freebsd-ports

Search DISTVERSION in Makefile:
https://github.com/freebsd/freebsd-ports/search?l=Makefile&
q=DISTVERSION&type=&utf8=%E2%9C%93
1,375 code results in freebsd/freebsd-ports

Regards,
sunpoet


>
>
> > Modified:
> >   head/www/rubygem-goldfinger/Makefile
> >
> > Modified: head/www/rubygem-goldfinger/Makefile
> > ============================================================
> ==================
> > --- head/www/rubygem-goldfinger/Makefile      Sun Aug  6 16:53:04 2017
>       (r447473)
> > +++ head/www/rubygem-goldfinger/Makefile      Sun Aug  6 16:53:09 2017
>       (r447474)
> > @@ -1,7 +1,7 @@
> >  # $FreeBSD$
> >
> >  PORTNAME=    goldfinger
> > -DISTVERSION= 2.0.1
> > +PORTVERSION= 2.0.1
> >  CATEGORIES=  www rubygems
> >  MASTER_SITES=        RG
> >
> > @@ -17,7 +17,6 @@ RUN_DEPENDS=        rubygem-addressable>=2.5:www/r
> ubygem-addr
> >               rubygem-oj>=3.0:devel/rubygem-oj
> >
> >  NO_ARCH=     yes
> > -
> >  USES=                gem
> >  USE_RUBY=    yes
> >
> >
> >
>
> --
> Mathieu Arnold
>
>