svn commit: r417795 - head/security/letskencrypt

[Mathieu Arnold]

+--On 4 juillet 2016 09:14:33 +0200 Bernard Spil <brnrd at FreeBSD.org> wrote:
| On 2016-07-04 0:27, Jason Unovitch wrote:
|> On Thu, Jun 30, 2016 at 11:19:20AM +0200, Bernard Spil wrote:
|>> -----BEGIN PGP SIGNED MESSAGE-----
|>> Hash: SHA1
|>> 
|>> On 2016-06-29 23:11, Mathieu Arnold wrote:
|>> > +--On 29 juin 2016 15:04:28 -0600 Adam Weinberger <adamw at adamw.org>
|>> > wrote:
|>> > |> On 29 Jun, 2016, at 14:55, Bernard Spil <brnrd at freebsd.org> wrote:
|>> > |> 
|>> > |> 
|>> > |> +USES=		gmake ssl:libressl tar:tgz
|>> > | 
|>> > | Is USES=ssl:libressl real? It seems like a great idea, but I didn't
|>> > | know it was a thing.
|>> > 
|>> > It's about the same as USES=ssl:foobar :-)
|>> 
|>> Just figured this out as well :D
|>> 
|>> Luckily it is a no-op, the ports framework just makes it ssl_ARGS 
|>> which
|>> is not used in Mk/Uses/ssl.mk.
|>> 
|>> The port takes care of the problem at the bottom of the Makefile
|>> 
|>> .if empty(SSL_DEFAULT:Mlibressl*)
|>> IGNORE= needs LibreSSL to build. set DEFAULT_VERSIONS+=ssl=libressl \
|>>         and rebuild all ports that depend on openssl
|>> .endif
|>> 
|>> which matches either security/libressl or security/libressl-devel.
|>> 
|> Can you fix the ssl:libressl then?  It doesn't make much sense to have
|> this non-functional line in the port.
| 
| Hi All,
| 
| Will do!
| 
| There's a snafu in the periodic script as well that needs fixing.
| 
| I've started re-working the LibreSSL dependency in the makefile to mimic
| the dependencies in Mk/Uses/ssl.mk
| 
| BUILD_DEPENDS=  libtls.so:security/libressl
| RUN_DEPENDS=    libtls.so:security/libressl

You will not put that in any port.  To depend on any *SSL library, you use
USES=ssl and mark the port BROKEN/IGNORE if the default SSL library is not
the right one.  Forcing the installation of a non default *SSL library is
really not the right thing to do.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 949 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20160704/6e3249d5/attachment.sig>