svn commit: r391421 - in head/sysutils: . docker docker/files

[Kris Moore]

On 07/07/2015 12:04, Adam Weinberger wrote:
> Hi Kris, I hope you don't feel like you're getting picked on for this port. But there are a few  unusual/non-optimal things in the Makefile:
Oh, no problem. I appreciate the extra eyes on the files.

>> +BUILD_DEPENDS=	${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
>> +		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
>> +		${LOCALBASE}/bin/git:${PORTSDIR}/devel/git \
>> +		sqlite3:${PORTSDIR}/databases/sqlite3
>> +RUN_DEPENDS=	${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
>> +		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
>> +		sqlite3:${PORTSDIR}/databases/sqlite3
> All of those programs are in ${PATH}. There is no need for the ${LOCALBASE}/bin/ stuff.
Done!

> Also, git is not used at any point and that dependency can be safely removed, especially given that you already pass DOCKER_GITCOMMIT in env.
Thanks for catching that. I was using it at one point, but passing in
DOCKER_GITCOMMIT= removes the need for it now.

>
>> +	${INSTALL} ${WRKSRC}/bundles/latest/binary/docker ${STAGEDIR}${PREFIX}/bin/
> You want ${INSTALL_PROGRAM} here, not bare ${INSTALL}.
Done!

> # Adam
>
>


-- 
Kris Moore
PC-BSD Software / iXsystems
Enterprise Storage & Servers Driven By Open Source