svn commit: r391421 - in head/sysutils: . docker docker/files

[Adam Weinberger]

Hi Kris, I hope you don't feel like you're getting picked on for this port. But there are a few  unusual/non-optimal things in the Makefile:

> +BUILD_DEPENDS=	${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
> +		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> +		${LOCALBASE}/bin/git:${PORTSDIR}/devel/git \
> +		sqlite3:${PORTSDIR}/databases/sqlite3
> +RUN_DEPENDS=	${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
> +		${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
> +		sqlite3:${PORTSDIR}/databases/sqlite3

All of those programs are in ${PATH}. There is no need for the ${LOCALBASE}/bin/ stuff.

Also, git is not used at any point and that dependency can be safely removed, especially given that you already pass DOCKER_GITCOMMIT in env.

> +	${INSTALL} ${WRKSRC}/bundles/latest/binary/docker ${STAGEDIR}${PREFIX}/bin/

You want ${INSTALL_PROGRAM} here, not bare ${INSTALL}.

# Adam


-- 
Adam Weinberger
adamw at adamw.org
http://www.adamw.org