svn commit: r383894 - in head/ports-mgmt/portlint: . src
Gerald Pfeifer
gerald at pfeifer.com
Mon Aug 3 07:19:48 UTC 2015
On Mon, 3 Aug 2015, John Marino wrote:
>> is wrong about emulators/wine-devel/files/patch-partial-reservation
>> and especially emulators/wine-devel/files/patch-dlls_kernel32_Makefile.in
>> or lang/gcc6-devel/patch-unwind-ia64.h ?
> Please don't relax it.
It is overy strict, so relaxing is the right thing to do.
> People were reverting good "UTC" patches before.
> Now they aren't, which is what that rule was trying to address.
Yes, except there are now lots of false positives. That is
a problem. It renders portlint less useful (to the point that
I am considering to not use it any longer since it's become an
uphill battle submitting patches and bug reports regarding the
increasing number of false positives coming from portlint).
> It's just a portlint warning, you don't have to worry about it
> for existing patching. It's basically there for new patches.
I am not planning to use `make makepatch`for new patches, either.
My patches are perfectly fine and do not exhibit the problem you
are concerned about, so why warn about them? In fact, `make
makepatch` would remove key information in some cases.
(Warning about patches that cary specific timezone information,
not ones that lack "UTC" makes sense, of course.)
Gerald
More information about the svn-ports-all
mailing list