svn commit: r383894 - in head/ports-mgmt/portlint: . src

John Marino freebsd.contact at marino.st
Mon Aug 3 06:43:26 UTC 2015


On 8/3/2015 7:19 AM, Gerald Pfeifer wrote:
> On Mon, 13 Apr 2015, Joe Marcus Clarke wrote:
>>   Update to 2.16.3.
>>   
>>   * Check the patches to make sure they were generated using ``make 
>>   patch'' [1]
> 
> Why this?  Looking both at this as well as the actual code...
> 
> 
> ...I cannot help feeling that this is a little over the edge.  What 
> is wrong about emulators/wine-devel/files/patch-partial-reservation 
> and especially emulators/wine-devel/files/patch-dlls_kernel32_Makefile.in
> or lang/gcc6-devel/patch-unwind-ia64.h ?
> 
> It appears the source of this is a somewhat underspecified request 
> in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197747
> 
> The problem are not actually "patches that don't have UTC in "---" line" 
> as stated there.  It's patches that feature a date and time there to being 
> with _and_ in a different format.
> 
> Mind relaxing this a bit again?

Please don't relax it.
People were reverting good "UTC" patches before.
Now they aren't, which is what that rule was trying to address.
It's just a portlint warning, you don't have to worry about it for
existing patching.  It's basically there for new patches.

John


More information about the svn-ports-all mailing list