PERFORCE change 129920 for review

Hans Petter Selasky hselasky at freebsd.org
Fri Feb 1 23:18:07 PST 2008


On Saturday 02 February 2008, Alfred Perlstein wrote:
> This change makes very little sense.  If xfer->frbuffers is a bare
> pointer, then why add 0 to it?  Just pass xfer->frbuffers or use a
> macro that explains what you are doing.
>

I can change those to a plain "xfer->frlengths". It was just a reminder for 
me, because some places we use "xfer->frlengths + 1" and "xfer->frbuffers + 
1".

I will write a script that converts all of those.

--HPS



More information about the p4-projects mailing list