PERFORCE change 129920 for review
Alfred Perlstein
alfred at freebsd.org
Fri Feb 1 18:40:52 PST 2008
This change makes very little sense. If xfer->frbuffers is a bare
pointer, then why add 0 to it? Just pass xfer->frbuffers or use a
macro that explains what you are doing.
* Hans Petter Selasky <hselasky at FreeBSD.org> [071201 16:01] wrote:
> http://perforce.freebsd.org/chv.cgi?CH=129920
>
> Change 129920 by hselasky at hselasky_laptop001 on 2007/12/02 00:00:47
>
>
> "buf_data" will be removed and replaced by "frbuffers + 0".
>
> Affected files ...
>
> .. //depot/projects/usb/src/sys/dev/usb/usb_compat_linux.c#12 edit
>
> Differences ...
>
> ==== //depot/projects/usb/src/sys/dev/usb/usb_compat_linux.c#12 (text+ko) ====
>
> @@ -1286,7 +1286,7 @@
> uipd = urb->iso_frame_desc + x;
> uipd->actual_length = xfer->frlengths[x];
> uipd->status = 0;
> - usbd_copy_out(&(xfer->buf_data), offset,
> + usbd_copy_out(xfer->frbuffers + 0, offset,
> ((uint8_t *)(urb->transfer_buffer)) + uipd->offset,
> uipd->actual_length);
> offset += max_frame;
> @@ -1354,7 +1354,7 @@
> for (x = 0; x < urb->number_of_packets; x++) {
> uipd = urb->iso_frame_desc + x;
> xfer->frlengths[x] = uipd->length;
> - usbd_copy_in(&(xfer->buf_data), offset,
> + usbd_copy_in(xfer->frbuffers + 0, offset,
> ((uint8_t *)(urb->transfer_buffer)) + uipd->offset,
> uipd->length);
> offset += uipd->length;
--
- Alfred Perlstein
More information about the p4-projects
mailing list