[RFC] USBdump patches

Weongyo Jeong weongyo.jeong at gmail.com
Tue Nov 23 22:39:41 UTC 2010


On Tue, Nov 23, 2010 at 11:19:33PM +0100, Hans Petter Selasky wrote:
> Hi,
> 
> Please find attached official usbdump patch from HPS trying to re-use as much 
> as possible of Weongyo's code which was committed not long ago. You need to 
> SVN up to the latest 9-current.
> 
> This patch should fix all USB-dump issues reported so far!
> 
> 1) Fix for proper offset calculation on ISOCHRONOUS reception.
> 2) Fixes for device mode.
> 3) PF-virtual-machine is OK (and done before copy of data).
> 4) Can load and unload the PF-code like a module.
> 
> How to use:
> 
> cd /usr/src
> cat usbdump_r215656_patch.txt | patch
> 
> You need to make new kernel, but not userland.
> 
> Install sys/dev/usb/usb_pf.h into /usr/include/dev/usb/ and make all install 
> in src/usr.sbin/usbdump .
> 
> After reboot:
> 
> kldload usb_pf
> 
> usbdump -d -1 -vvv
> 
> man usbdump

NACK.  You already could recognize that the patch is quite big and
multiple patches are mixed into one.  Please separate into smallest
pieces then send freebsd-usb@ again.  I don't want to do a jumbo jump.

regards,
Weongyo Jeong



More information about the freebsd-usb mailing list