roll call and USB "plan"

Julian Elischer julian at elischer.org
Fri Nov 5 14:19:07 PST 2004



Mike Tancsa wrote:

> At 04:15 PM 05/11/2004, Julian Elischer wrote:
>
>> 1/ where are we?
>>  I've seen USB commits recently from several people..
>
>
> Not a commit, but a plea to have
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/72935
>
> reviewed / committed if possible :)
> i


> how about:



> uhidopen(dev_t dev, int flag, int mode, usb_proc_ptr p)
> {
>         struct uhid_softc *sc;
>         usbd_status err;
>         int s;
>
>         USB_GET_SC_OPEN(uhid, UHIDUNIT(dev), sc);
>
>         DPRINTF(("uhidopen: sc=%p\n", sc));
>
>         if (sc->sc_dying)
>                 return (ENXIO);
>
>         /*
>          * HID devices tend to tromple in the TTY system's playground
>          * so we need to try make them play together.
>          * XXX This is far from perfect. It doesn't take into
>          * account removable devices for a start..
>          */
>         s = splhigh();
>         tty_imask |= bio_imask;
>         bio_imask |= tty_imask;
>         update_intr_masks();
>         splx( s );
>
>         if (sc->sc_state & UHID_OPEN)
>                 return (EBUSY);
>         sc->sc_state |= UHID_OPEN;
>

>
> I have been running with the patch in there for a week now heavily 
> hitting the sio and uhid devices without issue.  It would normally 
> take a day or two to trigger the panic without the patch.
>
>
>         ---Mike 




More information about the freebsd-usb mailing list