MFC req for 5.x/5.3

[Daniel Eischen]

On Fri, 29 Oct 2004, Julian Elischer wrote:

> when compiling these against RELENG_5 I see a couple of warnings in
> libpthread..
>
> cc -O -pipe  -DPTHREAD_KERNEL -I/usr/src/lib/libpthread/../libc/include
> -I/usr/s
> rc/lib/libpthread/thread  -I/usr/src/lib/libpthread/../../include
> -I/usr/src/lib
> /libpthread/arch/i386/include -I/usr/src/lib/libpthread/sys
> -I/usr/src/lib/libpt
> hread/../../libexec/rtld-elf
> -I/usr/src/lib/libpthread/../../libexec/rtld-elf/i3
> 86 -fno-builtin -D_LOCK_DEBUG -D_PTHREADS_INVARIANTS -Wall
> -I/usr/src/lib/libpth
> read/../libc/i386  -c /usr/src/lib/libpthread/thread/thr_kern.c
> /usr/src/lib/libpthread/thread/thr_kern.c: In function `_kse_alloc':
> /usr/src/lib/libpthread/thread/thr_kern.c:2204: warning: 'crit' might be
> used un
> initialized in this function
>
> cc -O -pipe  -DPTHREAD_KERNEL -I/usr/src/lib/libpthread/../libc/include
> -I/usr/s
> rc/lib/libpthread/thread  -I/usr/src/lib/libpthread/../../include
> -I/usr/src/lib
> /libpthread/arch/i386/include -I/usr/src/lib/libpthread/sys
> -I/usr/src/lib/libpt
> hread/../../libexec/rtld-elf
> -I/usr/src/lib/libpthread/../../libexec/rtld-elf/i3
> 86 -fno-builtin -D_LOCK_DEBUG -D_PTHREADS_INVARIANTS -Wall
> -I/usr/src/lib/libpth
> read/../libc/i386  -c /usr/src/lib/libpthread/thread/thr_mutex.c
> /usr/src/lib/libpthread/thread/thr_mutex.c: In function
> `_pthread_mutex_init':
> /usr/src/lib/libpthread/thread/thr_mutex.c:111: warning: 'type' might be
> used un
> initialized in this function
> /usr/src/lib/libpthread/thread/thr_mutex.c:112: warning: 'protocol'
> might be use
> d uninitialized in this function
> /usr/src/lib/libpthread/thread/thr_mutex.c:113: warning: 'ceiling' might
> be used
>  uninitialized in this function
> /usr/src/lib/libpthread/thread/thr_mutex.c:114: warning: 'flags' might
> be used u
> ninitialized in this function
>
> cc -O -pipe  -DPTHREAD_KERNEL -I/usr/src/lib/libpthread/../libc/include
> -I/usr/s
> rc/lib/libpthread/thread  -I/usr/src/lib/libpthread/../../include
> -I/usr/src/lib
> /libpthread/arch/i386/include -I/usr/src/lib/libpthread/sys
> -I/usr/src/lib/libpt
> hread/../../libexec/rtld-elf
> -I/usr/src/lib/libpthread/../../libexec/rtld-elf/i3
> 86 -fno-builtin -D_LOCK_DEBUG -D_PTHREADS_INVARIANTS -Wall
> -I/usr/src/lib/libpth
> read/../libc/i386  -c /usr/src/lib/libpthread/thread/thr_sem.c
> /usr/src/lib/libpthread/thread/thr_sem.c: In function `_sem_init':
> /usr/src/lib/libpthread/thread/thr_sem.c:126: warning: assignment makes
> integer
> from pointer without a cast
>
> cc -O -pipe  -DPTHREAD_KERNEL -I/usr/src/lib/libpthread/../libc/include
> -I/usr/s
> rc/lib/libpthread/thread  -I/usr/src/lib/libpthread/../../include
> -I/usr/src/lib
> /libpthread/arch/i386/include -I/usr/src/lib/libpthread/sys
> -I/usr/src/lib/libpt
> hread/../../libexec/rtld-elf
> -I/usr/src/lib/libpthread/../../libexec/rtld-elf/i3
> 86 -fno-builtin -D_LOCK_DEBUG -D_PTHREADS_INVARIANTS -Wall
> -I/usr/src/lib/libpth
> read/../libc/i386  -c /usr/src/lib/libpthread/thread/thr_symbols.c
> In file included from
> /usr/src/lib/libpthread/../../libexec/rtld-elf/rtld.h:40,
>                  from /usr/src/lib/libpthread/thread/thr_symbols.c:37:
> /usr/src/lib/libpthread/../../libexec/rtld-elf/i386/rtld_machdep.h: In
> function
> `reloc_jmpslot':
> /usr/src/lib/libpthread/../../libexec/rtld-elf/i386/rtld_machdep.h:49:
> warning:
> implicit declaration of function `dbg'
>
> Dan/David.. any of these anything to worry about? if not I'll commit to
> RELENG_5

No, we get those on -current as well.

-- 
Dan