mpt driver issue?

[Michael Tuexen]

> On 6 Nov 2016, at 20:41, Sean Bruno <sbruno at freebsd.org> wrote:
> 
> 
> 
> On 11/06/16 10:54, Michael Tuexen wrote:
>> Dear all,
>> 
>> it was suggested on current@ to forward this to freebsd-scsi@
>> 
>> The problem shows up since r308268 and it looks like an issue
>> in the mpt driver...
>> 
>> Best regards
>> Michael
> 
> I don't see any *obvious* reason that we should hold the mpt lock here.
> It looks ok to just drop it.
I tried that and the system (with WITNESS) panic'ed...
Can't write a core (not a surprise).

Best regards
Michael
> 
> sean
> 
> Index: sys/dev/mpt/mpt.c
> ===================================================================
> --- sys/dev/mpt/mpt.c   (revision 308345)
> +++ sys/dev/mpt/mpt.c   (working copy)
> @@ -2284,9 +2284,7 @@
>        mpt_lprt(mpt, MPT_PRT_DEBUG, "doorbell req = %s\n",
>            mpt_ioc_diag(mpt_read(mpt, MPT_OFFSET_DOORBELL)));
> 
> -       MPT_LOCK(mpt);
>        error = mpt_configure_ioc(mpt, 0, 0);
> -       MPT_UNLOCK(mpt);
> 
>        return (error);
> }
> 
> 
> 
> 
>