mpt driver issue?

[Sean Bruno]

On 11/06/16 10:54, Michael Tuexen wrote:
> Dear all,
> 
> it was suggested on current@ to forward this to freebsd-scsi@
> 
> The problem shows up since r308268 and it looks like an issue
> in the mpt driver...
> 
> Best regards
> Michael

I don't see any *obvious* reason that we should hold the mpt lock here.
It looks ok to just drop it.

sean

Index: sys/dev/mpt/mpt.c
===================================================================
--- sys/dev/mpt/mpt.c   (revision 308345)
+++ sys/dev/mpt/mpt.c   (working copy)
@@ -2284,9 +2284,7 @@
        mpt_lprt(mpt, MPT_PRT_DEBUG, "doorbell req = %s\n",
            mpt_ioc_diag(mpt_read(mpt, MPT_OFFSET_DOORBELL)));

-       MPT_LOCK(mpt);
        error = mpt_configure_ioc(mpt, 0, 0);
-       MPT_UNLOCK(mpt);

        return (error);
 }





-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 585 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-scsi/attachments/20161106/2ecee89d/attachment.sig>