question regarding style(9) and field initialisers in structs

Alexander Best arundel at freebsd.org
Sun Oct 30 14:58:08 UTC 2011


hi there,

i found hundreds of the following cases in the FreeBSD src:

[...]
struct periph_driver {
	periph_init_func_t	init;
	char			*driver_name;
	TAILQ_HEAD(,cam_periph)	units;
	u_int			generation;
	u_int			flags;
	#define CAM_PERIPH_DRV_EARLY	0x01
};
[...]
static struct periph_driver dadriver =
{
	dainit, "da",
	TAILQ_HEAD_INITIALIZER(dadriver.units), /* generation */ 0
};

...is it proper programming practice to forget about the last field, if it
would have been initialised to 0?

cheers.
alex


More information about the freebsd-questions mailing list