salt rc.d scripts (Was: RUN_DEPENDS for python based port)

[Doug Barton]

On 12/22/2011 16:32, Christer Edwards wrote:

> I must have horrible luck or something, but I've put together rc
> scripts and they don't work. This port sure is giving me a hard time!
> 
> Here is a link to the updated archive with the .sample suggestions
> applied as well as the rc scripts. Can anyone see what is wrong with
> them? I simply get complains that it isn't toggled to YES in the
> rc.conf, but it is..

Can you paste the actual error that you're getting, and the output of
'grep salt /etc/rc.conf /etc/rc.conf.local' please?

I reviewed your scripts, and there is nothing that should cause the
error you're describing. I even tried with and without
salt_master_enable in rc.conf and got the expected results for both.

There are some style problems and one real bug that are repeated for all
3 scripts. I attached a fixed version of one of them, hopefully that
will help you see what's needed to fix the other 2. Also, please review
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html,
especially the pre-commit checklist.


hth,

Doug

-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/

-------------- next part --------------
#!/bin/sh

# $FreeBSD$
#
# Salt Master startup script
#
# PROVIDE: salt-master
# REQUIRE: LOGIN
# KEYWORD: shutdown
#
# Add the following to /etc/rc.conf[.local] to enable this service
#
# salt_master_enable="YES"

. /etc/rc.subr

name="salt-master"
rcvar="salt_master_enable"

load_rc_config ${name}

: ${salt_master_enable:="NO"}

command="%%PREFIX%%/bin/${name}"
pidfile="/var/run/${name}.pid"
required_files="%%PREFIX%%/etc/salt/master"
command_args="-c $required_files -d"

run_rc_command "$1"