x11-toolkits/xview requires COMPAT_43TTY defined to build on -CURRENT

Mel Flynn mel.flynn+fbsd.ports at mailing.thruhere.net
Tue Aug 4 06:07:40 UTC 2009


On Monday 03 August 2009 19:09:49 Tom Uffner wrote:
> Mel Flynn wrote:
> > On Saturday 01 August 2009 15:34:34 Tom Uffner wrote:
> >> x11-toolkits/xview requires COMPAT_43TTY defined to build on -CURRENT
> >
> > In your kernel config.
>
> no. it was in my kernel config. my problem was that the port would not
> compile w/o the definition in the port makefiles.

Right, my bad, did my testing on a 7.x machine with my brain screwed on
wrong. Anyway, interesting reading in the svn log:
r191919 | ed | 2009-05-08 12:06:37 -0800 (Fri, 08 May 2009) | 9 lines

Burn TTY ioctl bridges in compat layers.

I really don't want any pieces of code to include ioctl_compat.h, so let
the ibcs2 and svr4 compat leave sgtty alone. If they want to support
sgtty, they should emulate it on top of termios, not sgtty.

The code has been marked with BURN_BRIDGES for a long time. ibcs2 and
svr4 are not really popular pieces of code anyway.
---------------------------------------------------------

So, the real fix should come from upstream. For the time being, this
should work, marked MAKE_JOBS_UNSAFE while I was in there. The OSVERSION
leaves a three week hole where things won't work, but that should be
acceptable.

--- x11-toolkits/xview/Makefile.orig    2009-08-03 21:38:34.000000000 -0800
+++ x11-toolkits/xview/Makefile 2009-08-03 22:05:39.000000000 -0800
@@ -32,12 +32,16 @@
 SUB_FILES=     pkg-message

 MAN1=          xview.1
+MAKE_JOBS_UNSAFE=      yes

 X11BASE2FIX=   clients/olwmslave/help_file.c   lib/libxview/help/help_file.c   \
                lib/libxview/misc/gettext.h     lib/libxview/textsw/txt_e_menu.c

 .include <bsd.port.pre.mk>

+.if ${OSVERSION} > 800089
+CFLAGS+=       -DCOMPAT_43TTY
+.endif
 pre-configure:
        @${REINPLACE_CMD} -e 's+/usr/local+${PREFIX}+;' \
          ${WRKSRC}/config/XView.cf

-- 
Mel


More information about the freebsd-ports mailing list