Make broken in 6.0 ([ports-i386@pointyhat.freebsd.org: empire-1.7 failed on i386 6])

[Harti Brandt]

On Tue, 11 Oct 2005, Kris Kennaway wrote:

KK>On Tue, Oct 11, 2005 at 10:00:24PM -0400, Kris Kennaway wrote:
KK>> For some reason a number of ports are failing with this error on the
KK>> latest build.  I suspect that a change may have been merged to some
KK>> part of the base system that broke them.  Can someone please take a
KK>> look?

I actually doubt that the $(shell ...) construct was ever supported in our 
make. The canonical way to assign the output of a shell command to a 
variable is

VERSION != sed <bs.spec -n -e '/Version: \(.*\)/s//\1/p'

we also support the SysV syntax:

VERSION :sh= ...

although that's not documented and should be avoided.

harti

KK>> 
KK>> Kris
KK>
KK>> ===>  Configuring for empire-1.7
KK>> ===>  Building for empire-1.7
KK>> Unknown modifier ' '
KK>> 
KK>> Error expanding embedded variable.
KK>> *** Error code 2
KK>
KK>This seems to be from make trying to execute a $(shell ...) command.
KK>This seems to be broken:
KK>
KK>VERSION=$(shell sed <bs.spec -n -e '/Version: \(.*\)/s//\1/p')
KK>
KK>xor# make -V VERSION
KK>Unknown modifier ' '
KK>
KK>Unknown modifier ' '
KK>
KK>Unknown modifier ' '
KK>
KK>PPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP
KK>+PPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP:.*
KK>
KK>I think this must have been broken in make(1) some time ago (if it
KK>ever worked)..the workaround for now is probably to make these ports
KK>use gmake instead [1].
KK>
KK>Kris
KK>
KK>[1] jasone actually discovered this when I was testing some of his
KK>other patches, which flagged this more explicitly as an error.