INDEX user-friendliness and SMP speed-up patch

Kris Kennaway kris at obsecurity.org
Mon Mar 15 04:26:28 PST 2004


On Mon, Mar 15, 2004 at 11:54:42AM +0100, Oliver Eikemeier wrote:
> Kris Kennaway wrote:
> 
> >+	if [ "${INDEX_PRISTINE}" != "" ]; then \
> >+		export LOCALBASE=/nonexistentlocal; \
> >+		export X11BASE=/nonexistentx; \
> >+	fi; \
> 
> Will you set DEFAULT_OPTIONS=yes here (for PR 64233), or should I test for 
> INDEX_PRISTINE?

Here would probably be the place for it.

> >+	cat $${tmpdir}/${INDEXFILE}.desc.* | perl 
> >${.CURDIR}/Tools/make_index | \
> >+		sed -e 's/  */ /g' -e 's/|  */|/g' -e 's/  *|/|/g' -e 
> >"s,$${LOCALBASE},/usr/local," \
> >+			-e "s,$${X11BASE},/usr/X11R6," -e 's./..g' | \
> 
> Is "s,$${LOCALBASE},/usr/local," "s,$${X11BASE},/usr/X11R6," appropriate
> if INDEX_PRISTINE is not defined?

Good point, I'll change that.

> >+.if defined(BUILDING_INDEX)
> >+describe: ${SUBDIR:S/^/describe./}
> >+
> >+.for i in ${SUBDIR}
> >+describe.$i:
> >+	@${MAKE} -B ${i:S/^/_/:S/$/.describe/} > 
> >${INDEX_TMPDIR}/${INDEXFILE}.desc.${i}
> >+.endfor
> >+.else
> > describe: ${SUBDIR:S/^/_/:S/$/.describe/}
> >+.endif
> 
> I always wondered why we don't have
> 
> .PHONY describe
> 
> and
> 
> .PHONY describe.$i
> 
> here. Any reasons for that?

Hmm, I'm not sure what that would do.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20040315/2d05fc1d/attachment.bin


More information about the freebsd-ports mailing list