INDEX user-friendliness and SMP speed-up patch

Oliver Eikemeier eikemeier at fillmore-labs.com
Mon Mar 15 02:54:45 PST 2004


Kris Kennaway wrote:

> +	if [ "${INDEX_PRISTINE}" != "" ]; then \
> +		export LOCALBASE=/nonexistentlocal; \
> +		export X11BASE=/nonexistentx; \
> +	fi; \

Will you set DEFAULT_OPTIONS=yes here (for PR 64233), or should I test for 
INDEX_PRISTINE?

> +	cat $${tmpdir}/${INDEXFILE}.desc.* | perl ${.CURDIR}/Tools/make_index | \
> +		sed -e 's/  */ /g' -e 's/|  */|/g' -e 's/  *|/|/g' -e "s,$${LOCALBASE},/usr/local," \
> +			-e "s,$${X11BASE},/usr/X11R6," -e 's./..g' | \

Is "s,$${LOCALBASE},/usr/local," "s,$${X11BASE},/usr/X11R6," appropriate
if INDEX_PRISTINE is not defined?

> +.if defined(BUILDING_INDEX)
> +describe: ${SUBDIR:S/^/describe./}
> +
> +.for i in ${SUBDIR}
> +describe.$i:
> +	@${MAKE} -B ${i:S/^/_/:S/$/.describe/} > ${INDEX_TMPDIR}/${INDEXFILE}.desc.${i}
> +.endfor
> +.else
>  describe: ${SUBDIR:S/^/_/:S/$/.describe/}
> +.endif

I always wondered why we don't have

.PHONY describe

and

.PHONY describe.$i

here. Any reasons for that?



More information about the freebsd-ports mailing list