ports/186610: Update port mail/assp to 14040 build
Rusty Nejdl
rnejdl at ringofsaturn.com
Sun May 18 18:50:01 UTC 2014
The following reply was made to PR ports/186610; it has been noted by GNATS.
From: Rusty Nejdl <rnejdl at ringofsaturn.com>
To: marino at freebsd.org
Cc: bug-followup at freebsd.org
Subject: Re: ports/186610: Update port mail/assp to 14040 build
Date: Sun, 18 May 2014 13:21:13 -0500
--=_f10cb3b33d774096f028f3faf853f693
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
On 2014-05-13 01:31, John Marino wrote:
> Stumbling upon this ....
>
> Comments:
> 1) The fixes don't include stage support, which is mandatory now
> 2) The patch set includes several files that aren't actually changed:
> - files/510.assp.in
> - files/assp.in
> - files/patch-assp.pl
> - files/pkg-install.in
> 3) the assp.pl patch doesn't end in a new line (see patchset)
> 4) :U is used, that's got to be changed to :tu now
>
> In this case, the use of git hurt. The patchset was blindly generated
> without noticing either the non-function svnid changes or the missing
> carriage return.
>
> I would fix these problems, then submit a new PR that has the words
> "support stage" in the title, with a new patch and then ask for the old
> PR to be closed. I suggest this approach because ports that support
> stage will be noticed first.
Marino,
I'm working on this today since I have a quiet moment. Any suggestions
on #3?
Rusty
--=_f10cb3b33d774096f028f3faf853f693
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html; charset=UTF-8
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style=3D'font-size: 10pt; font-family: Helvetica,Arial,sans-ser=
if'>
<p>On 2014-05-13 01:31, John Marino wrote:</p>
<blockquote type=3D"cite" style=3D"padding-left:5px; border-left:#1010ff 2p=
x solid; margin-left:5px"><!-- html ignored --><!-- head ignored --><!-- me=
ta ignored -->
<pre>Stumbling upon this ....
Comments:
1) The fixes don't include stage support, which is mandatory now
2) The patch set includes several files that aren't actually changed:
- files/510.assp.in
- files/assp.in
- files/patch-assp.pl
- files/pkg-install.in
3) the assp.pl patch doesn't end in a new line (see patchset)
4) :U is used, that's got to be changed to :tu now
In this case, the use of git hurt. The patchset was blindly generated
without noticing either the non-function svnid changes or the missing
carriage return.
I would fix these problems, then submit a new PR that has the words
"support stage" in the title, with a new patch and then ask for the old
PR to be closed. I suggest this approach because ports that support
stage will be noticed first.
</pre>
</blockquote>
<p>Marino,</p>
<p>I'm working on this today since I have a quiet moment. Any suggest=
ions on #3?</p>
<p>Rusty</p>
<div> </div>
</body></html>
--=_f10cb3b33d774096f028f3faf853f693--
More information about the freebsd-ports-bugs
mailing list