ports/186610: Update port mail/assp to 14040 build

John Marino freebsd.contact at marino.st
Tue May 13 06:40:01 UTC 2014


The following reply was made to PR ports/186610; it has been noted by GNATS.

From: John Marino <freebsd.contact at marino.st>
To: bug-followup at FreeBSD.org, rnejdl at ringofsaturn.com
Cc:  
Subject: Re: ports/186610: Update port mail/assp to 14040 build
Date: Tue, 13 May 2014 08:31:34 +0200

 Stumbling upon this ....
 
 Comments:
 1) The fixes don't include stage support, which is mandatory now
 2) The patch set includes several files that aren't actually changed:
 - files/510.assp.in
 - files/assp.in
 - files/patch-assp.pl
 - files/pkg-install.in
 3) the assp.pl patch doesn't end in a new line (see patchset)
 4) :U is used, that's got to be changed to :tu now
 
 In this case, the use of git hurt.  The patchset was blindly generated
 without noticing either the non-function svnid changes or the missing
 carriage return.
 
 I would fix these problems, then submit a new PR that has the words
 "support stage" in the title, with a new patch and then ask for the old
 PR to be closed.  I suggest this approach because ports that support
 stage will be noticed first.
 


More information about the freebsd-ports-bugs mailing list