ports/156171: port multimedia/mplayer patch-libao2-ao_oss.c is incorrect

[Zhihao Yuan]

The following reply was made to PR ports/156171; it has been noted by GNATS.

From: Zhihao Yuan <lichray at gmail.com>
To: bug-followup at FreeBSD.org, lichray at gmail.com
Cc:  
Subject: Re: ports/156171: port multimedia/mplayer patch-libao2-ao_oss.c is incorrect
Date: Thu, 14 Apr 2011 05:00:22 -0500

 I think I should point out that, this patch did nothing! It just sets
 samplerate TWICE for AC3. So if the problem is about AC3, AC3 is not
 affected.
 Then what about non-AC3 audio? It violates the standard by changing the order.
 
 The original bug report was here:
 http://lists.freebsd.org/pipermail/freebsd-multimedia/2009-January/009620.html
 
 Note that the report says "once the audio stream is interrupted, e.g.
 by pausing playback, it cannot be restarted". This means, the code is
 correct when the sound began to play, everything is correct. So I can
 only guess that: ao_data.format is changed when pausing. It sounds
 like crazy, but matches the behavior.
 
 -- 
 Zhihao Yuan
 The best way to predict the future is to invent it.