boost-libs and CXXFLAGS (Re: devel/boost-bjam)

[Baptiste Daroussin]

On Fri, May 10, 2013 at 06:25:35PM -0400, Mikhail T. wrote:
> On 10.05.2013 16:28, Mikhail T. wrote:
> > Though boost-libs are now built with the specified compiler, the compiler 
> > flags continue to be ignored.
> I think, it is as simple as this:
> 
>     Index: compiled.mk
>     ===================================================================
>     --- compiled.mk (revision 317825)
>     +++ compiled.mk (working copy)
>     @@ -12,9 +12,7 @@
>       BJAM_ARGS=     --layout=system \
>                      --prefix=${PREFIX}
> 
>     -.if ${ARCH} == amd64
>     -BJAM_ARGS+=    cxxflags=-fPIC
>     -.endif
>     +BJAM_ARGS+= cxxflags="${CXXFLAGS:N-O*}" cflags="${CFLAGS:N-O*}"
> 
>       NO_CCACHE=     yes
>       .if ${CC:T:Mgcc*}
> 
> I make sure to remove any -O* flags from the local settings, because boost 
> prefers to be compiled with -O3 and inserts that in place automatically -- there 
> is no good reason to overwrite that.
> 
> Also, it seems, the upstream wised up on the -fPIC flag -- it is now added, 
> where needed. Adding it, where /not/ needed (in static libraries and 
> executables), as the current compiled.mk is doing on amd64, only pessimises the 
> generated code a little bit.
> 

for fPIC I know that in a place, I don't remember which part it wasn't set
correctly so imho it needs to stay (I add problems during the exp-run).

For the rest approved, but please add a comment saying that boost prefers -O3.

If you want to join the office team so that you don't need any approval for
those fixes, well you are welcome in :) just add yourself to the wiki page.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-office/attachments/20130511/a90219a7/attachment.sig>