[Differential] [Updated] D4824: hyperv/hn: Implement LRO

[delphij (Xin Li)]

delphij added a comment.


  Looks good to me overall, consider this as a formal approval if there is no objection from Adrian by Monday.
  
  Could you please take a look at my inline comments and address them if they are reasonable?

INLINE COMMENTS
  sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:186 Will it be sensible to turn this into SYSCTL_INT with CTLFLAG_RDTUN, so users can check its value?
  sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c:410 Looks like this is never defined, but a quick glance suggests it won't hurt to have these code?  Can these be unifdef -D'ed (unconditionally compiled in)?

REVISION DETAIL
  https://reviews.freebsd.org/D4824

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: sepherosa_gmail.com, adrian, royger, decui_microsoft.com, howard0su_gmail.com, kmacy, honzhan_microsoft.com, delphij
Cc: freebsd-net-list