CFR: FEATURE macros for AUDIT/CAM/IPC/KTR/MAC/NFS/NTP/PMC/SYSV/...

Alexander Leidinger Alexander at Leidinger.net
Sat Feb 12 14:19:27 UTC 2011


On Fri, 11 Feb 2011 19:38:06 +0300 Anonymous <swell.k at gmail.com> wrote:

> Alexander Leidinger <Alexander at Leidinger.net> writes:
> 
> > Hi,
> >
> > during the last GSoC various FEATURE macros where added to the
> > system. Before committing them, I would like to get some review
> > (like if macro is in the correct file, and for those FEATURES where
> > the description was not taken from NOTES if the description is OK).
> >
> > If nobody complains, I would like to commit this in 1-2 weeks. If
> > you need more time to review, just tell me.
> [...]
> > Index: kern/kern_dtrace.c
> [...]
> > +FEATURE(kdtrace_hooks,
> > +    "Kernel DTrace hooks which are required to load DTrace kernel
> > modules"); +
> [...]
> > Index: kern/kern_lockstat.c
> [...]
> > +FEATURE(kdtrace_hooks, "Kernel DTRACE hooks");
> 
> Why description differs?

Good catch. I removed the second one completely in my working copy.

Bye,
Alexander.


More information about the freebsd-hackers mailing list