insufficient flag handling in tools/install.sh
Alexander Best
arundel at freebsd.org
Fri Feb 4 10:32:13 UTC 2011
On Fri Feb 4 11, Eygene Ryabinkin wrote:
> Alexander, good day.
>
> Fri, Feb 04, 2011 at 10:22:21AM +0000, Alexander Best wrote:
> > hi eygene. thanks a lot for your patch.
>
> You're welcome ;))
>
> > i made two changes:
> >
> > 1) also catch the -v option for install(1).
>
> Yep.
>
> > 2) install(1) accepts multiple directories as arguments, when he -d flag has
> > been specified. so i don't think it's necessary to iterate through all the
> > directories passed to install.sh and invoke install(1) with only one
> > argument at a time.
>
> I had overlooked that, thanks for spotting.
>
> > could you take a look at the attached patch?
>
> Looks fine and works for me, thanks!
cool. :) any committer volunteering to commit these changes? ;)
cheers.
alex
> --
> Eygene Ryabinkin ,,,^..^,,,
> [ Life's unfair - but root password helps! | codelabs.ru ]
> [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
--
a13x
More information about the freebsd-hackers
mailing list