insufficient flag handling in tools/install.sh

Eygene Ryabinkin rea at freebsd.org
Fri Feb 4 10:27:49 UTC 2011


Alexander, good day.

Fri, Feb 04, 2011 at 10:22:21AM +0000, Alexander Best wrote:
> hi eygene. thanks a lot for your patch.

You're welcome ;))

> i made two changes:
> 
> 1) also catch the -v option for install(1).

Yep.

> 2) install(1) accepts multiple directories as arguments, when he -d flag has
>    been specified. so i don't think it's necessary to iterate through all the
>    directories passed to install.sh and invoke install(1) with only one
>    argument at a time.

I had overlooked that, thanks for spotting.

> could you take a look at the attached patch?

Looks fine and works for me, thanks!
-- 
Eygene Ryabinkin                                        ,,,^..^,,,
[ Life's unfair - but root password helps!           | codelabs.ru ]
[ 82FE 06BC D497 C0DE 49EC  4FF0 16AF 9EAE 8152 ECFB | freebsd.org ]
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20110204/af0188b2/attachment.pgp


More information about the freebsd-hackers mailing list