config(8) patch for review for src dir handling
Jilles Tjoelker
jilles at stack.nl
Sun Dec 23 14:25:09 PST 2007
On Sun, Dec 23, 2007 at 10:40:39AM +0100, Dag-Erling Smørgrav wrote:
> Ed Maste <emaste at freebsd.org> writes:
> > Right now config(8) calls realpath("../..", ... to find the src path
> > to write into the kernel Makefile. I want to change this to use $PWD
> > with the last two path components removed, assuming it's the same dir
> > as ../.. .
> I'm worried that your patch assumes that $PWD is present and correct,
> for which there is no guarantee. What happens if you use getcwd()
> instead of getenv("PWD")?
getcwd() does not use $PWD, it returns a pathname without symlinks.
So that would lead to the original behaviour.
A better way could be to use $PWD if it is set and an absolute logical
pathname referring to the current directory, as in src/bin/pwd/pwd.c .
--
Jilles Tjoelker
More information about the freebsd-hackers
mailing list