config(8) patch for review for src dir handling

Dag-Erling Smørgrav des at des.no
Sun Dec 23 01:40:46 PST 2007


Ed Maste <emaste at freebsd.org> writes:
> Right now config(8) calls realpath("../..", ... to find the src path
> to write into the kernel Makefile.  I want to change this to use $PWD
> with the last two path components removed, assuming it's the same dir
> as ../.. .

I'm worried that your patch assumes that $PWD is present and correct,
for which there is no guarantee.  What happens if you use getcwd()
instead of getenv("PWD")?

DES
-- 
Dag-Erling Smørgrav - des at des.no


More information about the freebsd-hackers mailing list