ip_reass() - possibly incorrect goto

[Maxim Konovalov]

On Thu, 24 Mar 2005, 04:46-0600, Mike Silbersack wrote:

>
> On Wed, 23 Mar 2005, Maxim Konovalov wrote:
>
> > On Tue, 22 Mar 2005, 12:08-0800, Vijay.Singh at nokia.com wrote:
> >
> > > Hi hackers, I am looking at the ip_reass() routine. In case of the
> > > 1st fragment we create the reassembly queue. After the queue has
> > > been inserted in the hash bucket, the if () code does a " goto
> > > inserted". Should this be changed to "goto done" instead? Any code
> > > that is executed for the 1st fragment, like frag per packet limiting
> > > and complete reassembly are not valid. Am I mistaken?
> >
> > Yep, it seems you are right.  The second micro optimization - drop the
> > fragment early if maxfragsperpacket == 0.
> >
> > Andre, Mike, what do you think?
>
> Looks good to me.  Please tell us if you come up with any more optimizations
> for the reassembly code, Vijay.
[...]

Committed to HEAD.  Thanks, Vijay!

-- 
Maxim Konovalov