indent bugfix / added features

[Luigi Rizzo]

On Fri, Jun 11, 2004 at 04:07:40PM +0200, Jens Schweikhardt wrote:
> On Thu, Jun 10, 2004 at 09:53:07PM -0500, Chip Norkus wrote:
...
> # normalize the code a bit.  In doing so I discovered a few deficencies in
> # the stock FreeBSD (5.2-CURRENT) indent and decided to fix them, I
> # thought these might be fairly common wishes (and one of them is a
> # bugfix) and have attached a patch which does the following:
...
> #   I don't know if anyone would be interested in committing the bugfix (I
> # believe it is correct) or added features, but I hope someone else finds
> # this useful.
...
> I'm willing to commit this if you could demonstrate that it will not
> produce different output in the default case than it does now. Say,
> run the old an new versions against the FreeBSD src tree and make a diff
> which should vanish apart from the bug-fixing effects. If you want to
> make yourself known as a quality software engineer, do the same for
> various sets of indent options :-)

?? this sounds like an absurd request, please... 
 
First, for a small patch like this you are much better off looking 
at the source code diffs rather than checking the output in a 
necessarily small set of test cases. 
 
Second, either you trust the author (in which case his statement
"I believe is correct" is all you need), or you don't, in which
case you'd have to check the patch yourself in whatever way you 
believe suitable. Either way, I don't see how the additional
tests you are asking for would change your behaviour.

	cheers
	luigi