Eog Crash while opening jpeg-images with EXIF data

Joe Marcus Clarke marcus at marcuscom.com
Mon Feb 20 18:53:57 PST 2006


On Tue, 2006-02-21 at 11:40 +0900, Alexander Nedotsukov wrote:
> Pascal,
> Cast it to (char*) instead. And this is not the only place in that file. 
> You have to patch other memcpy()s too.

I think guchar * would be more apt, no?

Joe

> All the best,
> Alexander.
> Pascal Hofstee wrote:
> > i am noticing a consistent eog crash when opening jpeg images with EXIF
> > data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT
> >
> > The line that causes the crash is libeog/eog-metadata-reader.c:231
> >
> > memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read),
> > (void*)&buf[i], priv->size);
> >
> > I am about 99% sure the (int) typecast on priv->exit_chunk is truncating
> > the 64-bit pointer into 32-bits causing the application to segfault as a
> > result. I am not 100% on how to properly fix this.
> >
> > If any of you could have a look at this, that would be appreciated.
> >
> >   
> 
> _______________________________________________
> freebsd-gnome at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
> To unsubscribe, send any mail to "freebsd-gnome-unsubscribe at freebsd.org"
> 
-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20060220/e62147a9/attachment.bin


More information about the freebsd-gnome mailing list