Eog Crash while opening jpeg-images with EXIF data

Alexander Nedotsukov bland at FreeBSD.org
Mon Feb 20 19:12:30 PST 2006


Joe Marcus Clarke wrote:
> On Tue, 2006-02-21 at 11:40 +0900, Alexander Nedotsukov wrote:
>   
>> Pascal,
>> Cast it to (char*) instead. And this is not the only place in that file. 
>> You have to patch other memcpy()s too.
>>     
>
> I think guchar * would be more apt, no?
>   
Well, technically there will be no difference at all. But 
aesthetically... could be.
I preferred plain C char* in hope that it make clear to all that all we 
need is a byte pointer while guchar* needs a bit more knowledge from 
accident code reader (let's say s/he must be sure that guchar is not 
stands for GNU Unicode char which may be more that one byte in size) 
Nits... :-)
> Joe
>
>   
>> All the best,
>> Alexander.
>> Pascal Hofstee wrote:
>>     
>>> i am noticing a consistent eog crash when opening jpeg images with EXIF
>>> data (using MC-gnome, eog-2.13.91) on FreeBSD/amd64 7.0-CURRENT
>>>
>>> The line that causes the crash is libeog/eog-metadata-reader.c:231
>>>
>>> memcpy ((void*) ((int)(priv->exif_chunk) + priv->bytes_read),
>>> (void*)&buf[i], priv->size);
>>>
>>> I am about 99% sure the (int) typecast on priv->exit_chunk is truncating
>>> the 64-bit pointer into 32-bits causing the application to segfault as a
>>> result. I am not 100% on how to properly fix this.
>>>
>>> If any of you could have a look at this, that would be appreciated.
>>>
>>>   
>>>       
>> _______________________________________________
>> freebsd-gnome at freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
>> To unsubscribe, send any mail to "freebsd-gnome-unsubscribe at freebsd.org"
>>
>>     



More information about the freebsd-gnome mailing list