ports/75816: [PATCH] www/firefox: new mozilla.sh and package script

[Jose M Rodriguez]

El Sábado, 26 de Febrero de 2005 09:32, Joe Marcus Clarke escribió:
> On Fri, 2005-02-25 at 09:22 +0100, Jose M Rodriguez wrote:
> > El Viernes, 25 de Febrero de 2005 08:56, Joe Marcus Clarke escribió:
> > > Synopsis: [PATCH] www/firefox: new mozilla.sh and package script
> > > <snip/>
> >
> > Please, consider the cleanhome moz_pis for firefox.  This makes
> > firefox upgrades don't be hurt by local profile.
>
> This could be useful.  However, I have some concerns, and the
> comments in the script didn't help.  This removes the pluginreg.dat
> every time Firefox is started.  Will that have any negative effects? 
> What about performance?   Couldn't this be wrapped about the -ot
> comparison as well?  Also, you have a typo.  The file is XUL.mfasl,
> not XUL.mfast.
>

Firts, I think we have time until 1.1/1.5 landing, so this can be worked 
better.

- I think having moz_pis processing in the Makefile is a good thing, 
with or without this or that script.  The mozilla.sh script seems to be 
a common denominator and moz_pis the way to get special things.

- The actual script in latest post is:
#!/bin/sh
#

# S50cleanhome
# a script to polite ${HOME}/${MOZ_PIS_USER_DIR}

# We run in our own subshell

# First, verify protocol
[ "$1" != "start" ] && exit 1
[ -z "${MOZ_PIS_API}" -o ${MOZ_PIS_API} -ne 2 ] && exit 1
[ -z "${MOZ_PIS_MOZBINDIR}" -o ! -d "${MOZ_PIS_MOZBINDIR}" ] && exit 1
[ -z "${HOME}" -o ! -d "${HOME}" ] && exit 1
[ -z "${MOZ_PIS_USER_DIR}" -o ! -d "${HOME}/${MOZ_PIS_USER_DIR}" ] && 
exit 1

# Try to polite ${HOME}/${MOZ_PIS_USER_DIR}

# This must be really needed?
# rm -f "${$HOME}/${MOZ_PIS_USER_DIR}/pluginreg.dat"

# Try to polite profile dirs
if [ -f "${HOME}/${MOZ_PIS_USER_DIR}/profiles.ini" ]; then
    sed -e '/Path=/! d' -e "s,Path=,${HOME}/${MOZ_PIS_USER_DIR}/," \
        "${HOME}/${MOZ_PIS_USER_DIR}/profiles.ini" \
        | while read dir
    do
        [ ! -d "${dir}" ] && continue
        # at last, debian do this, we do for new builds
        # rm -f "${dir}/XUL.mfast"
        # make reclaculate compreg.dat, xpti.dat for new builds
        [ "${dir}/compreg.dat" -ot 
"${MOZ_PIS_MOZBINDIR}/components.ini" ] &&
            rm -f "${dir}/compatibility.ini" "${dir}/XUL.mfast"
    done
fi

I try to import debian work, but taking mozilla guidelines.

I don't remove pluginreg.dat. But this is done in debian and maybe 
needed.

As I comment in the pkg scripts, I'll prefer have just one .keepme file 
in ${PLUGINDIR} and make all ports, even plugins 'touch this'.

In any case, If I enable pluginreg.dat removal, must be after a safe age 
test.

The components.ini <-> compatibility.ini relaction and the removal of 
compatibility.ini to force 'recalculation' is documented.

The XUL.mfast has a typo, yes, but this is more a debian thing. I think 
that removing compatibility.ini will be enough

> Other than that, this is a very clever script, and will probably make
> upgrades more painless.
>

<snip/>

--
  josemi